Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable "go to definition" for CSS and Less #183

Closed
mrmckeb opened this issue Dec 4, 2022 · 4 comments · Fixed by #202
Closed

Enable "go to definition" for CSS and Less #183

mrmckeb opened this issue Dec 4, 2022 · 4 comments · Fixed by #202
Assignees
@mrmckeb
Labels
enhancement New feature or request
Milestone
v4.2.0

Comments

@mrmckeb
Copy link
Owner

mrmckeb commented Dec 4, 2022

This has been added for Sass (both variants) only for now.

We should now be able to rollout support for CSS using the same approach.
@mrmckeb mrmckeb added the enhancement New feature or request label Dec 4, 2022
@mariusGundersen
Copy link
Contributor

what is holding this back?

@mariusGundersen
Copy link
Contributor

I've tested it a bit and it seems like it should be straight forward to add this for less as well.

The only problem is the mapping of the sourcemaps back to the original location, as pointed out here: less/less.js#2033

That is, unless you start a nested line with & it will not go to the right line. The issue seems to be somewhere in postcss where it maps the output sourcemap from less and then picks the wrong column or something.

@mrmckeb
Copy link
Owner Author

mrmckeb commented Feb 18, 2023

Hi @mariusGundersen - just time, as I'm really the sole maintainer of this project and do all of this work in my free time. Thanks for #192!

@mrmckeb mrmckeb added this to the v4.2.0 milestone Feb 18, 2023
@mrmckeb mrmckeb self-assigned this Feb 18, 2023
@mrmckeb mrmckeb mentioned this issue Feb 18, 2023
Merged
@mrmckeb
Copy link
Owner Author

mrmckeb commented Feb 19, 2023

This is now available in v4.2.1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrmckeb mrmckeb

Labels
enhancement New feature or request
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging a pull request may close this issue.

test: add additional goToDefinition tests mrmckeb/typescript-plugin-css-modules
2 participants
@mariusGundersen @mrmckeb