Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 Beta drops support for tvOS? #713

Open
Duell10111 opened this issue Aug 5, 2024 · 6 comments
Open

V3 Beta drops support for tvOS? #713

Duell10111 opened this issue Aug 5, 2024 · 6 comments

Comments

@Duell10111
Copy link

I saw that the podspec of the new v3 versions does not contain the tvOS platform anymore.

s.platforms = { :ios => min_ios_version_supported }

Is this intended, as this would break my current Expo TVOS app. :D

Copy link

Guten Tag, Hans here. Thank you for your report! V3 of react-native-mmkv does indeed drop support for tvOS. This was a decision made to streamline our focus on other platforms. If you really need tvOS support, you may consider sticking with an earlier version. For any urgent needs, consider sponsoring the project to help prioritize issues you care about support here. Viel Dank!

Note: If you think I made a mistake by closing this issue, please ping @mrousavy to take a look.

@maintenance-hans maintenance-hans bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
@mrousavy
Copy link
Owner

mrousavy commented Aug 5, 2024

hans stop talking bullshit

tvOS did work, I think this is a mistake - can you make a PR to add it again and verify that this works? thanks! :)

@mrousavy mrousavy reopened this Aug 5, 2024
Copy link

it ain't much, but it's honest work

@mrousavy
Copy link
Owner

mrousavy commented Aug 5, 2024

😂

@mrousavy
Copy link
Owner

@Duell10111 can you add a PR to make tvOS work again?

@Duell10111
Copy link
Author

Hey @mrousavy,
currently I did not manage to get my app running with the new architecture regardless of mmkv.
But I would suggest that at first we would have to add tvOS to podspecs.

Should we add a tvOS example somewhere?
Do you already have a expo example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants