Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact #42

Open
alshapton opened this issue Aug 20, 2023 · 4 comments
Open

Contact #42

alshapton opened this issue Aug 20, 2023 · 4 comments

Comments

@alshapton
Copy link

Hi Alex - I know no way of contacting you as the owner of this repo.

Due to the inactivity of this repo, I cloned it and moved it forward with a work colleague so we could use it in our day to day work.

We did much work on it and wish to look at including that work in the main repo now that you have reactivated it.

This is the fork:

https://github.com/alshapton/adr-viewer

We would like to converse about how best to make this happen.

Cheers

Andrew

@mrwilson
Copy link
Owner

Hi Andrew, thanks for getting in contact. I really appreciate you forking and carrying on with the development when I wasn't able to.

I'll happily take a look at your fork and then we can discuss on this issue to come up with a plan to stage some of your changes across, if you're happy with that.

What do you think are the most valuable/high-priority things you've added in your fork?

@alshapton
Copy link
Author

I would think:
i) Configuration using a TOML file
ii) ability to change colours (colour-blindness-friendly)
iii) exclude specific ADRs from view (e.g. ones which may be out of date) by number
iv) Added a new template

A couple of other minor tweaks

@mrwilson
Copy link
Owner

I think that colour-blindness-friendly styles in the default template is the highest priority thing to pull across, that would be really useful.

I'm going to spend some time decomposing the __init__.py file and its corresponding test into smaller chunks, to split the parsing of the ADRs from the rendering of templates, and so any changes to templating would fall into the latter.

@alshapton
Copy link
Author

alshapton commented Aug 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants