Ghoul2 importer updates #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides skipping changing between object and pose mode to force matrix updates, we also set keyframes outside of the transform loop. It also doesnt change the scene frame anymore (no measurable performance gains though) -> implements: mrwonko#55
and some formating
One can now set default values for the base path and scale of imports and exports. Import GLA frame range is only drawn when range is selected for the animation import. Skin files can now be chosen via a dropdown instead of copied manually.
and some formating
New cfg parsing option will add all animations into NLA tracks which is faster than just importing all frames the usual way. Also added an option to export either from timeline markers or from NLA strips. TODO: Add custom properties for sequence looping and fps to the actions and maybe add a custom panel to change these in NLA view
SomaZ
force-pushed
the
gla-importer-updates
branch
from
92ec023
to
4bf6a91
Compare
Adds a panel in the nla editor, so editing the fps and looping from the overview of all animations is possible and added a second panel in the actions section of the dopesheet editor. So working on an action directly also shows the options directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides skipping changing between object and pose mode to force matrix updates, we also set keyframes outside of the transform loop.
It also doesnt change the scene frame anymore (no measurable performance gains though)
With the updated code I can import all rancor animation frames in round about 6 and a half minutes on my machine at no visual difference to the animations. Before it took nealy 40 minutes to import all these frames.
bpy.context.view_layer.update()#56 and fixes Import GLA taking very long time #39