Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Style Idea: Grid Group #8

Closed
mrwweb opened this issue Mar 22, 2021 · 7 comments
Closed

New Style Idea: Grid Group #8

mrwweb opened this issue Mar 22, 2021 · 7 comments

Comments

@mrwweb
Copy link
Owner

mrwweb commented Mar 22, 2021

This idea is for a much more aggressive layout style, unlike all the existing typography-focused ones, so I'm a little hesitant to add it. It might even be better as a different plugin.

The idea: use CSS grid to provide 2, 3, and 4 column layouts for any blocks put into a grid with that style. I think it could be done really nicely with only CSS styles, though some care would have to be taken to make sure that things like images and embeds are resized correctly.

My biggest question is whether this passes the "90%+ of sites need this" rule.

@rtvenge
Copy link
Collaborator

rtvenge commented Mar 23, 2021

@mrwweb Putting my critical cap on 😄: What would this give us that columns (or equal height columns) give us? Would it be multiple rows? Anything else?

If I have a complex layout, I generally make a custom block but maybe thats because the current columns don't cut it. 😄

Do you have an example of where this would be a good fit? I'm thinking maybe a 3-up/multi-row card layout?

@mrwweb
Copy link
Owner Author

mrwweb commented Mar 23, 2021

What would this give us that columns (or equal height columns) give us?

Better wrapping and multiple rows. Here's a page I built with that technique. Very similar to your link.

Example two 3-column blocks make a 3x2 grid but can't wrap to a 2x3 grid.

@rtvenge
Copy link
Collaborator

rtvenge commented Mar 25, 2021

@mrwweb it looks like your example is very similar to mine. I'm sold. I use something like this on almost every site.

@mrwweb
Copy link
Owner Author

mrwweb commented Mar 25, 2021

@rtvenge I was thinking about this on my dog walk this morning. I wonder if it's possible to create a standalone plugin for the Block Directory with this as a style or block variation. That would be an awesome tool to install only when you need it, and would then be available through the block library installer.

After all our conversations and talking through the different block ideas, it feels like maybe this plugin should really stick to styles for text blocks rather than branching out into layout. (Maybe the buttons at bottom block is an exception? #9)

@rtvenge
Copy link
Collaborator

rtvenge commented Mar 29, 2021

@mrwweb Good idea to keep a scope to this. I like a line in the sand on this so we don't get carried away. 😄

If you add to the Block Directory, is it a totally new plugin or does it live in this plugin but is a net-new block?

@mrwweb
Copy link
Owner Author

mrwweb commented Mar 30, 2021

@rtvenge It would definitely have to be a nice plugin, but it's a little unclear if it could be included in the block directory. I think it should qualify, but it clearly doesn't meet the standards because it's not a separate block. I opened a ticket asking for clarification.

@mrwweb
Copy link
Owner Author

mrwweb commented Apr 26, 2021

I think we've basically decided to stick to styles that are useful utility classes (small, single purpose) and mostly for Text blocks. I still think this thing should happen, just as a separate plugin. Closing for now.

@mrwweb mrwweb closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants