Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

make auth optional #24

Open
burningTyger opened this issue Dec 1, 2016 · 5 comments
Open

make auth optional #24

burningTyger opened this issue Dec 1, 2016 · 5 comments

Comments

@burningTyger
Copy link

I'm considering this service along with another docker container and would use it from within my private docker network. No auth needed.

@msokk
Copy link
Owner

msokk commented Dec 2, 2016

Would RENDERER_NO_ACCESS_KEY=true environment variable suffice?

@Reggino
Copy link
Contributor

Reggino commented Dec 2, 2016

Why not just set RENDERER_ACCESS_KEY=?

@msokk
Copy link
Owner

msokk commented Dec 2, 2016

That would need accessKey= to give the blank key as query param, might as well set some simple access key then.
I could change the default startup behaviour of not starting when no keys are defined, but that would make it unauthenticated by default.

@Reggino
Copy link
Contributor

Reggino commented Dec 2, 2016

But since RENDERER_ACCESS_KEY is set, one could reason that RENDERER_ACCESS_KEY= would imply that unauthenticated use is intended... When the environment var is missing, you could say the service isn't configured properly.

@burningTyger
Copy link
Author

burningTyger commented Dec 2, 2016

Since there is no encryption tied to authentication it creates a false impression of security. So if you either use the service through docker or standalone you will have to enable encryption somehow. I usually use an nginx reverse proxy for that. If I have that in place I might as well add basic auth since it can be handled in the same directive. I'd drop the auth token altogether.

BTW: Thank you very much for the awesome repo. I tried all the available solutions but yours works well and fast. I changed some dependencies to slim down the image a bit though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants