Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the CoreCLR isn't working correctly #483

Open
mstange opened this issue Feb 1, 2025 · 0 comments
Open

Some of the CoreCLR isn't working correctly #483

mstange opened this issue Feb 1, 2025 · 0 comments

Comments

@mstange
Copy link
Owner

mstange commented Feb 1, 2025

I'm not sure about the specifics, but I'm filing this issue as a placeholder.

When I made the change in #299 to process unmerged ETL files, this changed the behavior of some of @vvuk's CoreCLR integration code. Specifically, the names we get when we read the unmerged ETL file are different from the names we expect.

For example, for Microsoft-Windows-DotNETRuntimeRundown/CLRMethodRundown/MethodDCStartVerbose, we currently instead get the name Microsoft-Windows-DotNETRuntimeRundown/Method /DCStartVerbose (including the space) from the unmerged ETL.

As a workaround, one could create merged ETL file manually and feed it into samply import.

Vlad had some ideas for what might be needed to fix this, but I forgot the specifics. If someone wants to dig into this, I can try to find his message in the https://chat.mozilla.org/#/room/#profiler:mozilla.org backscroll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant