Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge message cleanup does not remove empty messages with :emojis: #38

Open
S-S-X opened this issue Apr 12, 2021 · 1 comment
Open
Labels
bug Something isn't working

Comments

@S-S-X
Copy link
Member

S-S-X commented Apr 12, 2021

Cleanup was improved a bit here: #35

Most part works, it does remove test emojis and it does throws messages not containing meaningful words to /dev/null.

However, if simple emoji is present in message then that message gets through even while emoji is not visible in mintest chat.
That is emojis which are not removed by https://github.com/minetest-beerchat/beerchat/blob/9b58f90ba0dc61563a6b7188bb86131dc4b8cbd6/plugin/cleaner.lua#L9-L15

So it seems like those are actually getting through that check and simply not rendered by minetest chat or they're converted and sent as unicode emojis which lua pattern matcher recognizes as something not in [%c%p%s].

@S-S-X S-S-X added the bug Something isn't working label Apr 12, 2021
@S-S-X
Copy link
Member Author

S-S-X commented Apr 12, 2021

Confirmed conversion happening at some stage, probably at Discord. Sending :smiley: from IRC will send text exactly as written.
This is good because what should be cleaned up is just things that minetest cannot handle which is emojis, so what is needed is semi reliable way to check for unicode emojis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant