Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the apostrophe/quotation marks in pyproject version replacement #156

Closed
crash5 opened this issue Nov 18, 2023 · 2 comments
Closed

Keep the apostrophe/quotation marks in pyproject version replacement #156

crash5 opened this issue Nov 18, 2023 · 2 comments

Comments

@crash5
Copy link

crash5 commented Nov 18, 2023

I'm using apostrophe ' for the config in my pyproject file like version = '0.0.0' but on poetry install/build and poetry dynamic-versioning commands the plugin replaces it with quotation " marks.

@mtkennerly
Copy link
Owner

This behavior would be coming from tomlkit. I do see this issue that says it was fixed: python-poetry/tomlkit#112 , although it doesn't say in which version. I just tested with the latest tomlkit version, and I was able to reproduce it, so I've opened a new ticket with them: python-poetry/tomlkit#325 . This affects the poetry version command as well, even without the plugin involved.

The plugin defers to whichever tomlkit version Poetry is using, so if it's fixed in tomlkit and then included in a Poetry update, then it'll be fixed for the plugin as well. Beyond that, it's out of my control, unfortunately.

In the meantime, I would suggest using double quotes just to avoid the issue.

@crash5
Copy link
Author

crash5 commented Nov 18, 2023

okay, thank you

@crash5 crash5 closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants