Unrecoverable error: closed

[andyleclair]

Hi!
We upgraded Bandit from 1.5.7 to 1.6.4 and started seeing a nonzero number of new Bandit.TransportError

It's a small percentage, but it seems like a regression. Happy to provide as much context as I can!

Stacktrace:

[andyleclair]

Downgrading to 1.5.7 makes this error go away

[mtrudel]

Are you able to deploy the branch at #453 and grab a trace based on the instructions therein?

[andyleclair]

Let me confer with my team. I'd prefer not to be handing errors to my clients in prod, but if it's load-related, I'm not sure I could reproduce on staging

[Tricote]

I'm on version 1.6.1 and I also get some of these:

lib/bandit/http1/socket.ex:437 Bandit.HTTPTransport.Bandit.HTTP1.Socket.socket_error!/1	
lib/bandit/http1/socket.ex:344 Bandit.HTTPTransport.Bandit.HTTP1.Socket.send_headers/4	
lib/bandit/http1/socket.ex:422 Bandit.HTTPTransport.Bandit.HTTP1.Socket.send_on_error/2	
lib/bandit/pipeline.ex:223 Bandit.Pipeline.handle_error/7	
lib/bandit/http1/handler.ex:12 Bandit.HTTP1.Handler.handle_data/3	
lib/bandit/delegating_handler.ex:18 Bandit.DelegatingHandler.handle_data/3	
/app/deps/thousand_island/lib/thousand_island/handler.ex:417 Bandit.DelegatingHandler.handle_continue/2	
gen_server.erl:2163 :gen_server.try_handle_continue/3

[andyleclair]

We noticed these errors originally on 1.6.3 and upgraded to 1.6.4 hoping it would fix it, but it did not.

[mtrudel]

If anyone is able to run the branch I linked to above and report back with dumps, that would greatly help with trying to resolve this (these?) issues

[andyleclair]

@mtrudel I'm going to try to run that on one server out of our prod fleet tomorrow. I'll do my best to report back findings