-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max height of dialog - perhaps more a question? #15
Comments
I had a look at the methods I could override - and tried a simple test in the code-behind of the dialog:
... but that doesn't make any difference ;-) Perhaps a different implementation of the above "thought" could do the trick - but apparently with some other code. |
I can see that I could set the |
If it were me I'd set proportional height to 1 with transparent overlay colour, have my contents vertically centered within a parent absolute layout, adding a tap gesture recogniser to the absolute layout and call DialogNotifier.Cancel when the tapped event fires, but I suppose you're looking for a more built-in way. Are you supposed to put 'h' in the if statement instead? Not sure why you've defined it if it wasn't for that... |
Ahh... the 'h' was just a test to be able to see what was going on in the debugger. I appreciate the way you suggest to do it. However, I feel it should be possible to do way simpler - if just I could get my hands on the height of the dialog and screen - and if the dialog is higher then 90% of the screen then set the proportional height to 0.9... - but I couldn't figure out where to make that happen. Once I had the heights then changing the proportional height didn't have any effect.... :-( |
Description
I have a dialog defined by this XAML:
The contents of the scroll view is edited by an administrator (in several languages) so it can take up a lot of space on devices with a small screen.
So if I set the
ProportionalHeight
the dialog will not auto size to fit the contents (and potentially look way too large/high). However, if there is a lot of content withoutProportionalHeight
the dialog will get bigger than the screen - and the user cannot read the entire message or press the button to close the dialog....Steps to Reproduce
Expected Behavior
That the dialog would not flow outside the actual screen
Actual Behavior
Dialog grows bigger than visual screen - and user can't close it
Platforms
Basic Information
Any suggestions I may have overlooked would be much appreciated :-)
The text was updated successfully, but these errors were encountered: