From 6d92896be1c91da6bf118b928e4f77084946b171 Mon Sep 17 00:00:00 2001 From: atomiks Date: Tue, 4 Feb 2025 16:47:19 +1100 Subject: [PATCH] [useAnchorPositioning] Ensure keepMounted is a private param --- .../react/src/menu/positioner/MenuPositioner.spec.tsx | 4 ++++ .../src/popover/positioner/PopoverPositioner.spec.tsx | 4 ++++ .../positioner/PreviewCardPositioner.spec.tsx | 4 ++++ .../react/src/select/positioner/SelectPositioner.spec.tsx | 4 ++++ .../src/tooltip/positioner/TooltipPositioner.spec.tsx | 4 ++++ packages/react/src/utils/useAnchorPositioning.ts | 8 ++------ 6 files changed, 22 insertions(+), 6 deletions(-) create mode 100644 packages/react/src/menu/positioner/MenuPositioner.spec.tsx create mode 100644 packages/react/src/popover/positioner/PopoverPositioner.spec.tsx create mode 100644 packages/react/src/preview-card/positioner/PreviewCardPositioner.spec.tsx create mode 100644 packages/react/src/select/positioner/SelectPositioner.spec.tsx create mode 100644 packages/react/src/tooltip/positioner/TooltipPositioner.spec.tsx diff --git a/packages/react/src/menu/positioner/MenuPositioner.spec.tsx b/packages/react/src/menu/positioner/MenuPositioner.spec.tsx new file mode 100644 index 0000000000..7d2fd6be13 --- /dev/null +++ b/packages/react/src/menu/positioner/MenuPositioner.spec.tsx @@ -0,0 +1,4 @@ +import { Menu } from '@base-ui-components/react'; + +// @ts-expect-error - `keepMounted` should not be available +; diff --git a/packages/react/src/popover/positioner/PopoverPositioner.spec.tsx b/packages/react/src/popover/positioner/PopoverPositioner.spec.tsx new file mode 100644 index 0000000000..bc729d2d77 --- /dev/null +++ b/packages/react/src/popover/positioner/PopoverPositioner.spec.tsx @@ -0,0 +1,4 @@ +import { Popover } from '@base-ui-components/react'; + +// @ts-expect-error - `keepMounted` should not be available +; diff --git a/packages/react/src/preview-card/positioner/PreviewCardPositioner.spec.tsx b/packages/react/src/preview-card/positioner/PreviewCardPositioner.spec.tsx new file mode 100644 index 0000000000..3843f7cf13 --- /dev/null +++ b/packages/react/src/preview-card/positioner/PreviewCardPositioner.spec.tsx @@ -0,0 +1,4 @@ +import { PreviewCard } from '@base-ui-components/react'; + +// @ts-expect-error - `keepMounted` should not be available +; diff --git a/packages/react/src/select/positioner/SelectPositioner.spec.tsx b/packages/react/src/select/positioner/SelectPositioner.spec.tsx new file mode 100644 index 0000000000..fe43ba5e8c --- /dev/null +++ b/packages/react/src/select/positioner/SelectPositioner.spec.tsx @@ -0,0 +1,4 @@ +import { Select } from '@base-ui-components/react'; + +// @ts-expect-error - `keepMounted` should not be available +; diff --git a/packages/react/src/tooltip/positioner/TooltipPositioner.spec.tsx b/packages/react/src/tooltip/positioner/TooltipPositioner.spec.tsx new file mode 100644 index 0000000000..6fcdcbe641 --- /dev/null +++ b/packages/react/src/tooltip/positioner/TooltipPositioner.spec.tsx @@ -0,0 +1,4 @@ +import { Tooltip } from '@base-ui-components/react'; + +// @ts-expect-error - `keepMounted` should not be available +; diff --git a/packages/react/src/utils/useAnchorPositioning.ts b/packages/react/src/utils/useAnchorPositioning.ts index 2407372855..30ffc7b709 100644 --- a/packages/react/src/utils/useAnchorPositioning.ts +++ b/packages/react/src/utils/useAnchorPositioning.ts @@ -67,8 +67,8 @@ export function useAnchorPositioning( collisionPadding = 5, sticky = false, arrowPadding = 5, - keepMounted = false, // Private parameters + keepMounted = false, floatingRootContext, mounted, trackAnchor = true, @@ -422,14 +422,10 @@ export namespace useAnchorPositioning { * @default true */ trackAnchor?: boolean; - /** - * Whether to keep the popup mounted in the DOM while it's hidden. - * @default false - */ - keepMounted?: boolean; } export interface Parameters extends SharedParameters { + keepMounted?: boolean; trackCursorAxis?: 'none' | 'x' | 'y' | 'both'; floatingRootContext?: FloatingRootContext; mounted: boolean;