Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] Fix Provider delay=0 not being respected #1416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Feb 5, 2025

Fixes #1404 (presumably, as the issue is missing some details).

The || fallback needs to be ?? to respect 0. This requires modifications in the delay provider to ensure the existing behavior to respect delays regarding a Provider being present or not

@atomiks atomiks added bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module! labels Feb 5, 2025
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit b6ad864
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/67a33271bf133a00089d0693
😎 Deploy Preview https://deploy-preview-1416--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tooltip] Delay seems to be ignored
3 participants