Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui][docs] Create more examples for Base UI #36193

Closed
5 of 9 tasks
mapache-salvaje opened this issue Feb 15, 2023 · 5 comments
Closed
5 of 9 tasks

[base-ui][docs] Create more examples for Base UI #36193

mapache-salvaje opened this issue Feb 15, 2023 · 5 comments
Assignees
Labels
docs Improvements or additions to the documentation examples Relating to /examples

Comments

@mapache-salvaje
Copy link
Contributor

mapache-salvaje commented Feb 15, 2023

Problem

The MUI docs currently contain many scaffold examples and template projects for Material UI, but we're lacking in comparable examples for Base UI. Developers shouldn't have to deal with any initial setup steps to start building with each of our libraries using any framework.

Solution

This is an umbrella issue to keep track of the progress in expanding our collection of Base UI examples.

As a first step, I've created #36112 to establish naming conventions in the examples folder to keep things organized.

From there, I'd like to reach parity with the Material UI examples, so we should plug Base into Create React App, Next.js, Vite, etc., both in JS and TS.

Scope

The scope of this issue is limited to bare-bones scaffold projects. I also want to build more templates and fully functional starter apps, but that will be for a separate issue.

I think it makes sense to add JS and TS examples together in one PR for each framework.

Tasks

  • Create Example Projects doc for Base UI

Base UI

Naming conventions

library-framework(-ts)

Library prefixes:

  • base-ui
  • joy-ui
  • material-ui

TypeScript examples get a -ts suffix.

base-ui-nextjs-ts
base-ui-nextjs-js // omit the "-js" flag since this is the default

base-ui-remix
mui-base-remix // needs to start with lib prefix "base-ui"

@mapache-salvaje mapache-salvaje added docs Improvements or additions to the documentation examples Relating to /examples labels Feb 15, 2023
@mapache-salvaje mapache-salvaje self-assigned this Feb 15, 2023
@mj12albert
Copy link
Member

mj12albert commented Apr 24, 2023

There could actually be more combinations between the CSS framework (e.g. Tailwind) + Base + the "application" framework (e.g. Vite) like this:

  • base-vite-sass
  • base-vite-tailwind
  • base-vite-system

What do you think @samuelsycamore ?

@mapache-salvaje
Copy link
Contributor Author

mapache-salvaje commented Apr 24, 2023

Absolutely @mj12albert ! The list here is just meant as a starting point for us to reach parity with the existing Material UI examples. Definitely open to creating more as we see fit.

@mapache-salvaje mapache-salvaje changed the title [docs] Create more examples for the Core libraries [docs] Create more examples for Base UI and Joy UI Aug 3, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 4, 2023

  1. I think that we could remove all the Gatsby examples, not worth the opportunity cost: https://npm-stat.com/charts.html?package=gatsby&from=2021-08-03&to=2023-08-03. It will be more time we can use to polish the other examples.
  2. Examples for Base UI don't make a lot of sense for me. I think having one for developers to provide bug reproduction would be fair, one for us internally to test different styling solutions would also be fair. But beyond??
    For the Joy Design version of Base UI, installation steps could be enough, https://ui.shadcn.com/docs/installation/remix. I'm afraid of how much time it could take to maintaine the 3-tuple of (TypeScript/JavaScript, Framework, Styling library).
  3. We need to revamp the CDN examples, they should use ESM now, not UMD.
  4. For the Joy UI examples, I think that having Next.js App Router is enough for the bulk of the need. I don't think that it would be a major hurdle if we didn't have other at the point of the stable release. However, a big 💯 to add analytics on the Material UI examples to know the actually need for each example. I'm guessing when I say only App Router.

@mapache-salvaje
Copy link
Contributor Author

@oliviertassinari all of that makes sense. I do think we should provide examples for Base + Tailwind + major frameworks, because there's enough of a demand for "MUI + Tailwind" that it's worth maintaining those. I'll pare down the lists here, and we can keep an eye on the Material UI analytics to see what else to prioritize (if anything).

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation examples Relating to /examples
Projects
None yet
Development

No branches or pull requests

3 participants