-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Remove border from the side nav #40326
Conversation
Netlify deploy previewhttps://deploy-preview-40326--material-ui.netlify.app/ Bundle size report |
Bold move, but comparing the experiences to https://www.notion.so/mui-org/Docs-infra-83ba469842104927bb13606b1e859ef4?pvs=4#7647eb75870c42a79dc5bdd85cc412e2, it makes sense. Side note: for Windows and macOS users like me who always have their scrollbar visible, the difference is very hard to notice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mui/design — curious if y'all have any thoughts! 😃 I'm still feeling it... |
Yep, definitely! That was what I was trying to show. When nothing is selected, it feels misaligned—something that Radix solved with the search field and the selected item.
I think we can iterate a bit more, some users seem to like it this way, and tbh I think this feels lighter than the current version, what imo is something we need in the docs. |
I'll close this one for now as I'm still not entirely sure 😃 We can return it soon — don't want to leave it lingering here. |
This PR removes the
border-right
from the documentation side nav. I've been flirting with this idea for a while, feeling like the docs are "heavy" somehow, and doing so helps a lot in alleviating this sentiment.