Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][Chip] The default dark mode design seems incorrect #40472

Closed
MonstraG opened this issue Jan 7, 2024 · 2 comments · Fixed by #40488
Closed

[joy-ui][Chip] The default dark mode design seems incorrect #40472

MonstraG opened this issue Jan 7, 2024 · 2 comments · Fixed by #40488
Assignees
Labels
component: chip This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy

Comments

@MonstraG
Copy link
Contributor

MonstraG commented Jan 7, 2024

Related page

https://mui.com/joy-ui/react-chip/

Kind of issue

Broken demo

Issue description

Looking at basic demo:
image

I don't see any background color or border or anything to indicate that this is a chip, this looks like a regular text.

Context

n/a

Search keywords: chip joy text broken

@MonstraG MonstraG added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Jan 7, 2024
@MonstraG
Copy link
Contributor Author

MonstraG commented Jan 7, 2024

In light mode, it's ok:
image

@zannager zannager added component: chip This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jan 8, 2024
@danilo-leal danilo-leal changed the title [joy] [Chip] default dark mode don't look like chip [joy-ui][Chip] The default dark mode design seems incorrect Jan 9, 2024
@danilo-leal danilo-leal removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Jan 9, 2024
@danilo-leal
Copy link
Contributor

Heya @MonstraG, thanks for opening the issue! The here is actually not with the Joy UI Chip component but rather with the docs demo container being a bit too light in dark mode (and the color used is very similar to the Joy UI gray palette); thus the Chip seemingly looks without a background. If you check the very first demo on the Chip page (Introduction demo), you'll see how you can see the Chip's background better as the container background color there is darker.

In any case, I opened the above-linked PR to tone down that container's dark mode color a bit more. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: chip This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants