Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency Between ThumbUpOffAltRounded and ThumbDownOffAltRounded Icons #40540

Closed
muradsofi opened this issue Jan 11, 2024 · 6 comments
Closed
Assignees
Labels
package: icons Specific to @mui/icons

Comments

@muradsofi
Copy link

muradsofi commented Jan 11, 2024

Steps to reproduce

https://mui.com/material-ui/material-icons/?theme=Rounded&query=Thumb

Steps:

  1. Open the Material UI icons library (Or link which is I provided).
  2. Compare the ThumbUpOffAltRounded and ThumbDownOffAltRounded icons.
  3. Notice the fill inconsistency where ThumbUpOffAltRounded is filled with black color and ThumbDownOffAltRounded is transparent.

Current behavior

The ThumbUpOffAltRounded icon is filled with black color, while the ThumbDownOffAltRounded icon is transparent inside, which leads to a visual inconsistency.

Expected behavior

Both ThumbUpOffAltRounded and ThumbDownOffAltRounded icons should have consistent fill styles (Both transparent)

Context

ThumbUpAltRounded and ThumbUpOffAltRounded icons appear to be the same in design, suggesting that the ThumbDownOffAltRounded might have been mistakenly created without a filled variant to match the ThumbUpOffAltRounded

Your environment

System: OS: macOS 14.1.1 Binaries: Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm pnpm: 8.4.0 - /opt/homebrew/bin/pnpm Browsers: Chrome: 120.0.6099.71 Edge: Not Found Safari: 17.1

Search keywords: ThumbUpOffAltRounded design inconsistency

@muradsofi muradsofi added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 11, 2024
@goswamianshuman
Copy link

Hey @muradsofi can you please add the screenshots for the problem, I think it will be more easier for everyone to get known with the issue.

@zannager zannager added the package: icons Specific to @mui/icons label Jan 11, 2024
@muradsofi
Copy link
Author

@goswamianshuman Sure :)

As U can see from attached images, ThumbUpAltRounded and ThumbUpOffAltRounded are identical. However, technically, ThumbUpOffAltRounded should not have a filled color and should match the design of ThumbDownOffAltRounded.

Screenshot 2024-01-12 at 14 28 12
Screenshot 2024-01-12 at 14 27 46
Screenshot 2024-01-12 at 14 27 55

@goswamianshuman
Copy link

goswamianshuman commented Jan 12, 2024

@muradsofi I saw the issue, I want to ask that are you interested to work with this issue? If not then I will like to ask the maintainer to allow me for solving this issue.😊

@muradsofi
Copy link
Author

@goswamianshuman Sorry saw the comment now, unfortunately I don't have enough "design" skills to fix this icon issue 😅
Feel free to contact maintaner. Thank U 🙌

@goswamianshuman
Copy link

@goswamianshuman Sorry saw the comment now, unfortunately I don't have enough "design" skills to fix this icon issue 😅
Feel free to contact maintaner. Thank U 🙌

Sure! then I'll open a PR here.😺

@michaldudak
Copy link
Member

While it looks like a bug, it's consistent with Material Icons - see https://fonts.google.com/icons?icon.query=thumb+up+off+alt&icon.set=Material+Icons&icon.style=Rounded and https://fonts.google.com/icons?icon.query=thumb+down+off+alt&icon.set=Material+Icons&icon.style=Rounded

We don't accept fixes and any contributions that depart from what's in the Material Icons library. Please open an issue in Google's Material Icons repo to have this fixed.

@michaldudak michaldudak closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
@zannager zannager removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: icons Specific to @mui/icons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants