-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency Between ThumbUpOffAltRounded and ThumbDownOffAltRounded Icons #40540
Comments
Hey @muradsofi can you please add the screenshots for the problem, I think it will be more easier for everyone to get known with the issue. |
@goswamianshuman Sure :) As U can see from attached images, ThumbUpAltRounded and ThumbUpOffAltRounded are identical. However, technically, ThumbUpOffAltRounded should not have a filled color and should match the design of ThumbDownOffAltRounded. |
@muradsofi I saw the issue, I want to ask that are you interested to work with this issue? If not then I will like to ask the maintainer to allow me for solving this issue.😊 |
@goswamianshuman Sorry saw the comment now, unfortunately I don't have enough "design" skills to fix this icon issue 😅 |
Sure! then I'll open a PR here.😺 |
While it looks like a bug, it's consistent with Material Icons - see https://fonts.google.com/icons?icon.query=thumb+up+off+alt&icon.set=Material+Icons&icon.style=Rounded and https://fonts.google.com/icons?icon.query=thumb+down+off+alt&icon.set=Material+Icons&icon.style=Rounded We don't accept fixes and any contributions that depart from what's in the Material Icons library. Please open an issue in Google's Material Icons repo to have this fixed. |
Steps to reproduce
https://mui.com/material-ui/material-icons/?theme=Rounded&query=Thumb
Steps:
Current behavior
The ThumbUpOffAltRounded icon is filled with black color, while the ThumbDownOffAltRounded icon is transparent inside, which leads to a visual inconsistency.
Expected behavior
Both ThumbUpOffAltRounded and ThumbDownOffAltRounded icons should have consistent fill styles (Both transparent)
Context
ThumbUpAltRounded and ThumbUpOffAltRounded icons appear to be the same in design, suggesting that the ThumbDownOffAltRounded might have been mistakenly created without a filled variant to match the ThumbUpOffAltRounded
Your environment
Search keywords: ThumbUpOffAltRounded design inconsistency
The text was updated successfully, but these errors were encountered: