Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][docs] Switch demo run in sandbox leads to UI unexpected behavior #40634

Closed
ANUGLYPLUGIN opened this issue Jan 16, 2024 · 3 comments · Fixed by #40638
Closed

[base-ui][docs] Switch demo run in sandbox leads to UI unexpected behavior #40634

ANUGLYPLUGIN opened this issue Jan 16, 2024 · 3 comments · Fixed by #40638
Assignees
@zanivan
Labels
component: switch This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: base-ui Specific to @mui/base support: docs-feedback Feedback from documentation page

Comments

@ANUGLYPLUGIN
Copy link
Contributor

ANUGLYPLUGIN commented Jan 16, 2024 •
edited by github-actions bot
Loading

Related page

https://mui.com/base-ui/react-switch/

Kind of issue

Unclear explanations

Issue description

  • If you run first example opened in sandbox page, you will get UI problem when you switch to true state.
    image
  • You can see the thumb not align center.
  • I think it should tell these attribute like below, or user get trouble when copy/paste the snippet.
    image

Context

Expected copy/paste result or how they get the expected result.

Search keywords: mui, base-ui, switch
@ANUGLYPLUGIN ANUGLYPLUGIN added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Jan 16, 2024
@michaldudak michaldudak added docs Improvements or additions to the documentation design This is about UI or UX design, please involve a designer labels Jan 16, 2024
@ANUGLYPLUGIN
Copy link
Contributor Author

That will be all right for me.
image

@zanivan
Copy link
Contributor

zanivan commented Jan 16, 2024

Good catch @ANUGLYPLUGIN !

I believe that adding the box-sizing: border-box; to the demos would solve! I'll open a PR for this. Thanks for the feedback!

@zanivan zanivan added component: switch This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 16, 2024
@zanivan zanivan mentioned this issue Jan 16, 2024
Merged
1 task
@danilo-leal danilo-leal changed the title [docs] Docs example run in sandbox leads to UI unexpected behavior [base-ui][docs] Switch demo run in sandbox leads to UI unexpected behavior Jan 16, 2024
@ANUGLYPLUGIN
Copy link
Contributor Author

No problem @zanivan !

This was referenced Jan 17, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanivan zanivan

Labels
component: switch This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: base-ui Specific to @mui/base support: docs-feedback Feedback from documentation page
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[base-ui][switch] Add border-box to demos zanivan/material-ui
3 participants
@michaldudak @zanivan @ANUGLYPLUGIN