Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react 18 alongside 17 as peer dependency of @mui/styles #40678

Closed
RaananW opened this issue Jan 18, 2024 · 1 comment
Closed

Add react 18 alongside 17 as peer dependency of @mui/styles #40678

RaananW opened this issue Jan 18, 2024 · 1 comment
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.

Comments

@RaananW
Copy link

RaananW commented Jan 18, 2024 •
edited by github-actions bot
Loading

The current react peer dependency is 17.x, but types allow 17 and 18. Is it possible to add 18 to the react dependency as well?

material-ui/packages/mui-styles/package.json

Line 73 in 290f06e

"react": "^17.0.0"

Search keywords:
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 18, 2024
@samuelsycamore
Copy link
Contributor

Hi @RaananW, @mui/styles was deprecated in 2021 and is no longer maintained. It is not compatible with React 18.

@samuelsycamore samuelsycamore closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
@samuelsycamore samuelsycamore added package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 18, 2024
@Janpot Janpot mentioned this issue Feb 1, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RaananW @samuelsycamore