Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Style external (target blank) links differently #41072

Closed
danilo-leal opened this issue Feb 12, 2024 · 3 comments · Fixed by #41129
Closed

[docs-infra] Style external (target blank) links differently #41072

danilo-leal opened this issue Feb 12, 2024 · 3 comments · Fixed by #41129
Assignees
@siriwatknp @danilo-leal
Labels
component: link This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product

Comments

@danilo-leal
Copy link
Contributor

danilo-leal commented Feb 12, 2024 •
edited
Loading

A different style for links that take the reader to a different tab is a good practice for managing their expectations, clearly communicating it's an external resource.

Next.js WorkOS Radix Linear
Screenshot 2023-08-05 at 18 28 55 Screenshot 2023-08-05 at 18 28 29 Screenshot 2023-08-05 at 18 28 05 Screenshot 2023-08-05 at 18 27 50

Search keywords: external, links
@danilo-leal danilo-leal added status: waiting for maintainer These issues haven't been looked at yet by a maintainer design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 12, 2024
@danilo-leal danilo-leal self-assigned this Feb 12, 2024
@danilo-leal danilo-leal moved this to Selected in Docs-infra Feb 12, 2024
@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Feb 12, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 12, 2024 •
edited
Loading

See https://www.notion.so/mui-org/Olivier-design-review-on-Joy-Design-3ada9a7bcfa44b9fab1fe5032dfb33bb#b8bdf13b84d24887afcc5e26c8bfe199 for the context.

This could also be considered as an improvement opportunity for the Link component of Material UI and Joy UI.

@oliviertassinari oliviertassinari added the component: link This is the name of the generic UI component, not the React module! label Feb 12, 2024
@siriwatknp siriwatknp mentioned this issue Feb 16, 2024
Merged
1 task
@danilo-leal danilo-leal moved this from Selected to In progress in Docs-infra Feb 16, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Docs-infra Feb 19, 2024
@oliviertassinari
Copy link
Member

This could also be considered as an improvement opportunity for the Link component of Material UI and Joy UI.

How about we create an issue for this?

@oliviertassinari
Copy link
Member

Here we go #41270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siriwatknp siriwatknp

@danilo-leal danilo-leal

Labels
component: link This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product
Projects
Docs-infra
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs-infra] Add external link arrow siriwatknp/material-ui
3 participants
@oliviertassinari @siriwatknp @danilo-leal