Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui][Dialog] The "Confimation dialog" demo has incorrect description #41398

Closed
rejetto opened this issue Mar 7, 2024 · 3 comments · Fixed by #43488
Closed
Labels
component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. package: material-ui Specific to @mui/material

Comments

@rejetto
Copy link
Contributor

rejetto commented Mar 7, 2024

Related page

https://mui.com/material-ui/react-dialog/

Kind of issue

Unclear explanations

Issue description

the text says "or pressing Back, cancels the action and closes the dialog", but i tried both on desktop and phone, with Chrome, and "back" doesn't work, acting like the dialog wasn't even there

Context

No response

Search keywords: example description not matching

@rejetto rejetto added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Mar 7, 2024
@danilo-leal danilo-leal changed the title "basic dialog" example doesn't support back button [material-ui][docs] The "Basic dialog" example doesn't support back button Mar 7, 2024
@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Mar 7, 2024
@danilo-leal
Copy link
Contributor

Yeah, it's a bit unclear what "back" means here. I wonder if it's referring to the old Android nav bar where there was the circle, square, and triangle nav buttons, and the triangle was often the "go back" option.

@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][docs] The "Basic dialog" example doesn't support back button [docs][material-ui][Dialog] The "Basic dialog" example doesn't support back button Aug 22, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui][Dialog] The "Basic dialog" example doesn't support back button [docs][material-ui][Dialog] The "Confimation dialog" demo has incorrect description Aug 22, 2024
@ZeeshanTamboli
Copy link
Member

There's no Back button or icon. I think we should remove that text:

--- a/docs/data/material/components/dialogs/dialogs.md
+++ b/docs/data/material/components/dialogs/dialogs.md
@@ -113,7 +113,7 @@ function MyComponent() {
 Confirmation dialogs require users to explicitly confirm their choice before an option is committed.
 For example, users can listen to multiple ringtones but only make a final selection upon touching "OK".

-Touching "Cancel" in a confirmation dialog, or pressing Back, cancels the action, discards any changes, and closes
the dialog.
+Touching "Cancel" in a confirmation dialog, cancels the action, discards any changes, and closes the dialog.

@ZeeshanTamboli ZeeshanTamboli added good first issue Great for first contributions. Enable to learn the contribution process. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Aug 22, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @rejetto! How was your experience with our support team?
If you could spare a moment, we'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. package: material-ui Specific to @mui/material
Projects
None yet
4 participants