Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After applying high contrast themes, there is no differentiation between selected and non-selected control in Windows. #44141

Open
msftedad opened this issue Oct 17, 2024 · 5 comments
Assignees
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! platform: windows ready to take Help wanted. Guidance available. There is a high chance the change will be accepted waiting for 👍 Waiting for upvotes

Comments

@msftedad
Copy link

msftedad commented Oct 17, 2024

Steps to reproduce

Link to live example: (required)
https://mui.com/material-ui/react-button/

Prerequisites:
Turn on High Contrast Aquatic/Desert Modes (Go to settings->Contrast Themes->High Contrast aquatic/Desert Themes).

Steps:

  1. Open URL-https://mui.com/material-ui/react-button/
  2. "React Material UI." page will get Open.
  3. Press Tab key to navigate to left navigation section and select radio group option.
  4. Press Tab key to "Customization" section.
  5. Verify with tab key whether after applying high contrast themes, there is no differentiation between selected and non-selected radio button control.

Current behavior

After applying high contrast themes, there is no differentiation between selected and non-selected radio buttons.

Expected behavior

After applying high contrast themes, there should be differentiation, or border should be present on selected radio button.

Context

No response

Your environment

Radio Group

Planned

Search keywords: contrast themes, Radio group

@msftedad msftedad added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 17, 2024
@zannager zannager added the component: button This is the name of the generic UI component, not the React module! label Oct 17, 2024
@DiegoAndai DiegoAndai assigned siriwatknp and unassigned DiegoAndai Oct 17, 2024
@siriwatknp
Copy link
Member

Is this a feature request? Do you have any reference for the high contrast behavior?

@siriwatknp siriwatknp added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 21, 2024
Copy link

Since the issue is missing key information and has been inactive for 7 days, it has been automatically closed. If you wish to see the issue reopened, please provide the missing information.

@msftedad
Copy link
Author

Hi @siriwatknp, issue is still repro, customization Radio buttons icon is not visible in high contract Aquatic/Desert theme. please attachments.

image

Reference for the high contrast behavior
Customization Radio buttons icon in high contract Aquatic/Desert theme should be visible as "Radio group" controls.

Reference attachments:
image

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 29, 2024
@github-actions github-actions bot reopened this Oct 29, 2024
@DiegoAndai DiegoAndai added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 24, 2024
@DiegoAndai
Copy link
Member

Hey @msftedad, thanks for the report!

I added the waiting for 👍🏼 label so the community can vote for this new feature. If you want to see this fixed, please add a 👍🏼 reaction to the issue's description.

I added the ready to take label in case anyone wants to work on this before the team gets to it. Please reach out if you're interested, I'll gladly guide you.

@DiegoAndai DiegoAndai assigned DiegoAndai and unassigned siriwatknp Dec 24, 2024
@DiegoAndai DiegoAndai added this to the Material UI v8 (draft) milestone Dec 24, 2024
@DiegoAndai DiegoAndai added waiting for 👍 Waiting for upvotes ready to take Help wanted. Guidance available. There is a high chance the change will be accepted labels Dec 24, 2024
@msftedad
Copy link
Author

@DiegoAndai , I have added the label to see this fixed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! platform: windows ready to take Help wanted. Guidance available. There is a high chance the change will be accepted waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

4 participants