Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does mui still use react prop-types library? #45082

Closed
heath-freenome opened this issue Jan 21, 2025 · 3 comments
Closed

Why does mui still use react prop-types library? #45082

heath-freenome opened this issue Jan 21, 2025 · 3 comments
Labels
support: question Community support but can be turned into an improvement

Comments

@heath-freenome
Copy link
Contributor

heath-freenome commented Jan 21, 2025

Doing a source-graph search on "from 'prop-types'" that the library is imported almost 600 times. With React 19 removing propTypes support, I'm very curious whether the library will eventually stop using it? I am asking here because I couldn't figure out how to ask in the Discussions tab

Search keywords:

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 21, 2025
@mj12albert mj12albert added support: question Community support but can be turned into an improvement and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 22, 2025
@mj12albert
Copy link
Member

@heath-freenome The main reason we are still using proptypes now is that the API docs on the site are (still) generated from the *.propTypes blocks in the components, so the biggest blocker for removing it is that the docs generation/infra will need to be reworked

Though even without the proptypes package, there are situations where having runtime type checking could be useful: #43138

@heath-freenome
Copy link
Contributor Author

@mj12albert Thanks for the response. Good luck finding a doc generation solution that works as well, if not better than a prop-types one

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@heath-freenome How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support: question Community support but can be turned into an improvement
Projects
None yet
Development

No branches or pull requests

2 participants