Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix /base-ui redirect and prune links #45083

Merged
merged 9 commits into from
Jan 22, 2025

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Jan 22, 2025

Deleted the corresponding page to make the redirect work, also added a redirect in the Next.js config (for client side routing)

@mj12albert mj12albert added the docs Improvements or additions to the documentation label Jan 22, 2025
@mj12albert
Copy link
Member Author

https://deploy-preview-45083--material-ui.netlify.app/base-ui/
Even with the trailing slash it isn't working 🤔

@mj12albert
Copy link
Member Author

The redirect appears to be correct in the netlify deploy log: https://app.netlify.com/sites/material-ui/deploys/67909b10db98830008a44b56#L1449

@mj12albert
Copy link
Member Author

mj12albert commented Jan 22, 2025

Turns out ! is needed as in /base-ui https://base-ui.com 301! because the corresponding page/file for /base-ui isn't deleted

https://docs.netlify.com/routing/redirects/rewrites-proxies/#shadowing

@mj12albert mj12albert changed the title [docs] Add trailing slash to base-ui redirect [docs] Force /base-ui redirect Jan 22, 2025
@mj12albert mj12albert marked this pull request as ready for review January 22, 2025 10:05
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @alexfauquette suggested somewhere else, I think it's better to remove the page instead of using !

"A library of unstyled React components and low-level hooks. With MUI Base, you gain complete control over your app's CSS and accessibility features.",
link: '/base-ui/',
'Unstyled UI components for building accessible web apps and design systems, focusing on accessibility, performance, and developer experience.',
link: 'https://base-ui.com',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this on the /core page instead of removing it, otherwise it would look weird with only 3 cards

Screenshot 2025-01-22 at 6 45 48 PM

https://deploy-preview-45084--material-ui.netlify.app/core/

Copy link
Contributor

@colmtuite colmtuite Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 cards is fine. The only important thing here is to remove links pointing to the website (but keep docs links)

Copy link
Member

@aarongarciah aarongarciah Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 cards:
Screenshot 2025-01-22 at 12 31 55

3 cards and changing the grid to use 3 columns instead of 2:
Screenshot 2025-01-22 at 12 33 29

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK ~ I tweaked the grid size fff310a

@mj12albert mj12albert changed the title [docs] Force /base-ui redirect [docs] Fix /base-ui redirect and prune links Jan 22, 2025
@mj12albert mj12albert mentioned this pull request Jan 22, 2025
1 task
@@ -4,6 +4,7 @@ title: React Accordion component
components: Accordion, AccordionDetails, AccordionGroup, AccordionSummary
githubLabel: 'component: accordion'
waiAria: https://www.w3.org/WAI/ARIA/apg/patterns/accordion/
unstyled: https://base-ui.com/react/components/accordion
Copy link
Member Author

@mj12albert mj12albert Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Joy UI docs, I've added the corresponding (new) Base UI page when applicable
e.g. https://deploy-preview-45084--material-ui.netlify.app/joy-ui/react-accordion/#unstyled

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good shout

@mj12albert mj12albert merged commit c172f6d into mui:master Jan 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants