-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix /base-ui
redirect and prune links
#45083
Conversation
https://deploy-preview-45083--material-ui.netlify.app/base-ui/ |
The redirect appears to be correct in the netlify deploy log: https://app.netlify.com/sites/material-ui/deploys/67909b10db98830008a44b56#L1449 |
477c918
to
025df7d
Compare
Turns out https://docs.netlify.com/routing/redirects/rewrites-proxies/#shadowing |
/base-ui
redirect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @alexfauquette suggested somewhere else, I think it's better to remove the page instead of using !
1851abb
to
17f1a6e
Compare
"A library of unstyled React components and low-level hooks. With MUI Base, you gain complete control over your app's CSS and accessibility features.", | ||
link: '/base-ui/', | ||
'Unstyled UI components for building accessible web apps and design systems, focusing on accessibility, performance, and developer experience.', | ||
link: 'https://base-ui.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3 cards is fine. The only important thing here is to remove links pointing to the website (but keep docs links)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK ~ I tweaked the grid size fff310a
/base-ui
redirect/base-ui
redirect and prune links
@@ -4,6 +4,7 @@ title: React Accordion component | |||
components: Accordion, AccordionDetails, AccordionGroup, AccordionSummary | |||
githubLabel: 'component: accordion' | |||
waiAria: https://www.w3.org/WAI/ARIA/apg/patterns/accordion/ | |||
unstyled: https://base-ui.com/react/components/accordion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the Joy UI docs, I've added the corresponding (new) Base UI page when applicable
e.g. https://deploy-preview-45084--material-ui.netlify.app/joy-ui/react-accordion/#unstyled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good shout
Deleted the corresponding page to make the redirect work, also added a redirect in the Next.js config (for client side routing)