From 0e3e43b9b5054e8b5b2041c675ef3bf76b5a1f87 Mon Sep 17 00:00:00 2001 From: delangle Date: Wed, 14 Aug 2024 10:32:26 +0200 Subject: [PATCH] Review: Olivier --- .../tree-view/rich-tree-view-pro/rich-tree-view-pro.json | 2 +- .../x-tree-view-pro/src/RichTreeViewPro/RichTreeViewPro.tsx | 2 +- .../src/TreeViewVirtualScroller/TreeViewVirtualScrollbar.tsx | 2 +- .../src/TreeViewVirtualScroller/TreeViewVirtualScroller.tsx | 1 - .../useTreeViewVirtualization/useTreeViewVirtualization.ts | 2 +- .../useTreeViewVirtualization.types.ts | 2 +- 6 files changed, 5 insertions(+), 6 deletions(-) diff --git a/docs/translations/api-docs/tree-view/rich-tree-view-pro/rich-tree-view-pro.json b/docs/translations/api-docs/tree-view/rich-tree-view-pro/rich-tree-view-pro.json index 81639368619ae..0bae70fd0c1c1 100644 --- a/docs/translations/api-docs/tree-view/rich-tree-view-pro/rich-tree-view-pro.json +++ b/docs/translations/api-docs/tree-view/rich-tree-view-pro/rich-tree-view-pro.json @@ -138,7 +138,7 @@ "resizeThrottleMs": { "description": "The millisecond throttle delay for resizing the Tree View when virtualization is enabled." }, - "scrollBufferPx": { "description": "Region in pixels to render before/after the viewport" }, + "scrollBufferPx": { "description": "Region in pixels to render before/after the viewport." }, "selectedItems": { "description": "Selected item ids. (Controlled) When multiSelect is true this takes an array of strings; when false (default) a string." }, diff --git a/packages/x-tree-view-pro/src/RichTreeViewPro/RichTreeViewPro.tsx b/packages/x-tree-view-pro/src/RichTreeViewPro/RichTreeViewPro.tsx index 4b76b97167fe2..e871e32d0f5db 100644 --- a/packages/x-tree-view-pro/src/RichTreeViewPro/RichTreeViewPro.tsx +++ b/packages/x-tree-view-pro/src/RichTreeViewPro/RichTreeViewPro.tsx @@ -332,7 +332,7 @@ RichTreeViewPro.propTypes = { */ resizeThrottleMs: PropTypes.number, /** - * Region in pixels to render before/after the viewport + * Region in pixels to render before/after the viewport. * @default 150 */ scrollBufferPx: PropTypes.number, diff --git a/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScrollbar.tsx b/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScrollbar.tsx index c695a86817dbc..cdfd805e61a0f 100644 --- a/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScrollbar.tsx +++ b/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScrollbar.tsx @@ -46,7 +46,7 @@ export const TreeViewVirtualScrollbar = React.forwardRef< } = useTreeViewContext<[UseTreeViewVirtualizationSignature]>(); const isLocked = React.useRef(false); const lastPosition = React.useRef(0); - const scrollbarRef = React.useRef(null); + const scrollbarRef = React.useRef(null); const contentRef = React.useRef(null); const dimensions = instance.getDimensions(); diff --git a/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScroller.tsx b/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScroller.tsx index f5ec4d46a6b59..93d78fb75c255 100644 --- a/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScroller.tsx +++ b/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScroller.tsx @@ -16,7 +16,6 @@ const TreeViewVirtualScrollerRoot = styled('div', { '--TreeView-scrollbarSize': '10px', '--TreeView-hasScrollX': '0', '--TreeView-hasScrollY': '0', - flexGrow: 1, position: 'relative', overflow: 'hidden', diff --git a/packages/x-tree-view-pro/src/internals/plugins/useTreeViewVirtualization/useTreeViewVirtualization.ts b/packages/x-tree-view-pro/src/internals/plugins/useTreeViewVirtualization/useTreeViewVirtualization.ts index 3ea33c38091e9..2667c8e803f7c 100644 --- a/packages/x-tree-view-pro/src/internals/plugins/useTreeViewVirtualization/useTreeViewVirtualization.ts +++ b/packages/x-tree-view-pro/src/internals/plugins/useTreeViewVirtualization/useTreeViewVirtualization.ts @@ -81,7 +81,7 @@ export const useTreeViewVirtualization: TreeViewPlugin