Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] SingleSelect columns stopped getting the label correctly for "is any of" starting from 7.0.0-alpha.7 #11755

Closed
rodrigofariow opened this issue Jan 19, 2024 · 8 comments · Fixed by #11939
Assignees
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature good first issue Great for first contributions. Enable to learn the contribution process. regression A bug, but worse support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/

Comments

@rodrigofariow
Copy link

rodrigofariow commented Jan 19, 2024

Steps to reproduce

Link to live example: https://next.mui.com/x/react-data-grid/filtering/

You can see it clearly on your demos
Steps:

  1. Select "Country" filter
  2. Select "is any of" operator
  3. Select a country

Current behavior

The value is shown on the text input instead of the label:

image

Expected behavior

In https://mui.com/x/react-data-grid/filtering/ (latest 6.x) you have the expected behaviour:

image

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: datagrid single select
Order ID: 79531

@rodrigofariow rodrigofariow added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 19, 2024
@rodrigofariow rodrigofariow changed the title DataGrid - singleSelect columns stopped getting the label correctly for "is any of" starting from 7.0.0-alpha.7 DataGrid - Premium - SingleSelect columns stopped getting the label correctly for "is any of" starting from 7.0.0-alpha.7 Jan 19, 2024
@zannager zannager added component: data grid This is the name of the generic UI component, not the React module! support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/ labels Jan 19, 2024
@michelengelen
Copy link
Member

Thanks @rodrigofariow for raising this issue with us. 🙇🏼
We will certainly have a look at this.

@cherniavskii since this seems like a small regression could it be a "good first issue"?

@michelengelen michelengelen added regression A bug, but worse feature: Filtering Related to the data grid Filtering feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 22, 2024
@michelengelen michelengelen changed the title DataGrid - Premium - SingleSelect columns stopped getting the label correctly for "is any of" starting from 7.0.0-alpha.7 [data grid] SingleSelect columns stopped getting the label correctly for "is any of" starting from 7.0.0-alpha.7 Jan 22, 2024
@cherniavskii
Copy link
Member

cherniavskii commented Jan 22, 2024

@michelengelen Sure, why not

@cherniavskii
Copy link
Member

The regression is most probably coming from #11330

@michelengelen michelengelen added the good first issue Great for first contributions. Enable to learn the contribution process. label Jan 22, 2024
@gitstart
Copy link
Contributor

gitstart commented Feb 5, 2024

@michelengelen @cherniavskii we would like to pick this up

@rodrigofariow
Copy link
Author

rodrigofariow commented Feb 12, 2024

Any news @cherniavskii @michelengelen ?

In understand it's considered a small regression but it's a regression that is preventing us from updating to latest alpha versions and incrementally deal with breaking changes.

@michelengelen
Copy link
Member

@rodrigofariow there is a PR currently open for this. We just did not have the time to look at it yet. I will see it through, ok?

Copy link

⚠️ This issue has been closed.
If you have a similar problem, please open a new issue and provide details about your specific problem.
If you can provide additional information related to this topic that could help future readers, please feel free to leave a comment.

How did we do @rodrigofariow?
Your experience with our support team matters to us. If you have a moment, please share your thoughts through our brief survey.

@michelengelen
Copy link
Member

@rodrigofariow the PR just got merged, so you can expect the changes to hit the new version by the end of the week! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature good first issue Great for first contributions. Enable to learn the contribution process. regression A bug, but worse support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants