Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] range styling is being added to cells inside of the range instead of just the edges of the range #11891

Closed
RyleySill93 opened this issue Jan 31, 2024 · 8 comments · Fixed by #12230
Assignees
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Cell Selection Related to the cell selection feature plan: Premium Impact at least one Premium user regression A bug, but worse v7.x

Comments

@RyleySill93
Copy link

RyleySill93 commented Jan 31, 2024

Steps to reproduce

Link to live example: https://mui.com/x/react-data-grid/cell-selection/#customize-range-styling

image

Current behavior

MuiDataGrid-cell--rangeBottom is being applied to a cell in the middle of the range.

Expected behavior

MuiDataGrid-cell--rangeBottom should only be applied to cells in the last row of the range.

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: datagrid range styling
Order ID: 75803

@RyleySill93 RyleySill93 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 31, 2024
@michelengelen
Copy link
Member

Hey @RyleySill93 could you provide detailed steps you took to get to this bug?
If I try it is always correct:

Screenshot 2024-02-01 at 12 06 38

Thanks! 🙇🏼

@michelengelen michelengelen added component: data grid This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information feature: Cell Selection Related to the cell selection feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 1, 2024
@michelengelen michelengelen changed the title DataGrid range styling is being added to cells inside of the range instead of just the edges of the range [data grid] range styling is being added to cells inside of the range instead of just the edges of the range Feb 1, 2024
@RyleySill93
Copy link
Author

@michelengelen I'm just clicking on that link and highlighting a range of cells using click and drag or shift + arrow keys. Tried with Chrome, Safari, and Firefox

test.mov

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Feb 1, 2024
@michelengelen
Copy link
Member

Oh, yes ... now I can reproduce as well ... it happens with all of the range classes.
Thanks for raising this issue. 🙇🏼 We will have a look.

@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Feb 2, 2024
@michelengelen michelengelen added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 2, 2024
@gitstart
Copy link
Contributor

gitstart commented Feb 5, 2024

@michelengelen @RyleySill93 we would like to pick this up

@louisaaron
Copy link

We're experiencing this as well and are planning to roll out our grid-based feature in the next two weeks. @michelengelen are you able to provide an estimated timeline for this one? If beyond 2-3 weeks we'll probably go ahead and create our own internal fix. Thanks so much!

Support Key/Order ID: 85118

@romgrk
Copy link
Contributor

romgrk commented Feb 27, 2024

Which grid version will you be using? Can you use the v7 releases? This should be straightforward to fix this week.

@cherniavskii cherniavskii added regression A bug, but worse plan: Premium Impact at least one Premium user v7.x and removed bug 🐛 Something doesn't work labels Feb 27, 2024
Copy link

⚠️ This issue has been closed.
If you have a similar problem, please open a new issue and provide details about your specific problem.
If you can provide additional information related to this topic that could help future readers, please feel free to leave a comment.

How did we do @RyleySill93?
Your experience with our support team matters to us. If you have a moment, please share your thoughts through our brief survey.

@louisaaron
Copy link

Thanks guys!

@cherniavskii cherniavskii moved this from 🆕 Needs refinement to ✅ Done in MUI X Data Grid Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Cell Selection Related to the cell selection feature plan: Premium Impact at least one Premium user regression A bug, but worse v7.x
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants