Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] This import breaks build via rsbuild #13764

Closed
iCoderXXI opened this issue Jul 8, 2024 · 2 comments
Closed

[pickers] This import breaks build via rsbuild #13764

iCoderXXI opened this issue Jul 8, 2024 · 2 comments
Labels
component: pickers This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists

Comments

@iCoderXXI
Copy link

iCoderXXI commented Jul 8, 2024

import longFormatters from 'date-fns/_lib/format/longFormatters';

There is no need to import longFormatters from _lib/format/longFormatters because it is reexported in /format.

image

Search keywords:

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 8, 2024
@zannager zannager added the component: pickers This is the name of the generic UI component, not the React module! label Jul 8, 2024
@LukasTy
Copy link
Member

LukasTy commented Jul 8, 2024

Hello, you are probably checking the AdapterDateFns code, which is designed to work with date-fns v2.
It does not export longFormatters: https://github.com/date-fns/date-fns/blob/v2/src/format/index.ts

AdapterDateFnsV3 is designed to work with date-fns v3 and is using this export:

import { format as dateFnsFormat, longFormatters } from 'date-fns/format';

You can read more about this in the documentation.

I'm closing it as this looks like a duplicate of #12758, #12467, #12282, #12144.

Feel free to reopen this issue if you still see a problem. 😉

@LukasTy LukasTy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@LukasTy LukasTy added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@iCoderXXI: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@michelengelen michelengelen changed the title This import breaks build via rsbuild [pickers] This import breaks build via rsbuild Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants