Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Overlays aren't sticky in RTL mode #14289

Open
h03ein1376 opened this issue Aug 22, 2024 · 7 comments
Open

[data grid] Overlays aren't sticky in RTL mode #14289

h03ein1376 opened this issue Aug 22, 2024 · 7 comments
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! i18n internationalization

Comments

@h03ein1376
Copy link

h03ein1376 commented Aug 22, 2024

Steps to reproduce

Link to live example: (document)

Current behavior

Data Grid Overlays aren't sticky in RTL mode:
image

Expected behavior

It should be sticky, just like in LTR mode:
image

Search keywords: Data Grid Overlays RTL

@h03ein1376 h03ein1376 added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 22, 2024
@github-actions github-actions bot added the component: data grid This is the name of the generic UI component, not the React module! label Aug 22, 2024
@michelengelen
Copy link
Member

Confirmed ... I'll add this to the board!
Thanks for raising this @h03ein1376 👍🏼

@michelengelen michelengelen added accessibility a11y and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 22, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Aug 22, 2024
@michelengelen michelengelen changed the title Data Grid Overlays aren't sticky in RTL mode [data grid] Overlays aren't sticky in RTL mode Aug 22, 2024
@kalyan90
Copy link
Contributor

kalyan90 commented Oct 8, 2024

@michelengelen I attempted to replicate the issue but couldn't identify the problem. I'd like to contribute by investigating further - could you please provide the steps to help me troubleshoot? Understood the issue

@kalyan90
Copy link
Contributor

@michelengelen @arminmeh is use useRtl hook working in grid components. As per mui docs we have to wrap the component with RTLProvider https://mui.com/material-ui/migration/migrating-to-pigment-css/#migrating-from-theme-direction

@kalyan90
Copy link
Contributor

@romgrk can you please help here?

@michelengelen @arminmeh is use useRtl hook working in grid components. As per mui docs we have to wrap the component with RTLProvider https://mui.com/material-ui/migration/migrating-to-pigment-css/#migrating-from-theme-direction

@romgrk
Copy link
Contributor

romgrk commented Oct 18, 2024

I'm not sure, but I would expect this to be fixable with just CSS.

@kalyan90
Copy link
Contributor

Added a PR to address this issue. #15072

@oliviertassinari oliviertassinari added i18n internationalization and removed accessibility a11y labels Nov 5, 2024
@romgrk romgrk moved this from 🆕 Needs refinement to 🔖 Ready in MUI X Data Grid Nov 6, 2024
@romgrk
Copy link
Contributor

romgrk commented Nov 6, 2024

The issue seems fixed on some platforms and still present in others (macOS at least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! i18n internationalization
Projects
Status: 🔖 Ready
Development

No branches or pull requests

5 participants