Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Add separate render method for aggregation row #15125

Open
Vagizova opened this issue Oct 25, 2024 · 2 comments
Open

[data grid] Add separate render method for aggregation row #15125

Vagizova opened this issue Oct 25, 2024 · 2 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature new feature New feature or request

Comments

@Vagizova
Copy link

Vagizova commented Oct 25, 2024

Summary

So when you use custom aggregation functions, you will most likely have to add renderCell, check if it is an aggregation row or not, etc. but in this case you are actually using renderCell for every cell, although it is only needed for one row. Using this in every cell significantly reduces the performance of the table as a whole

We have a large table, hundreds of rows by hundreds of columns. so this significantly reduces the performance. We have already applied all the tips from the page

how about having something like separate aggregationCellRender on column def lvl? so we can render value in each

if it is not possible, it would be grate you can explain why and how i can avoid performance issue

Motivation

let's optimize as many places in this table as possible, i really want to use your product, but right now it doesn't seem possible

Search keywords: aggregation footer render

@Vagizova Vagizova added new feature New feature or request status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 25, 2024
@Vagizova
Copy link
Author

Vagizova commented Oct 25, 2024

Another finding: Is it possible to set Height to aggregation row separately? why? because I have to do something like that:

const getRowHeight = useCallback(
    ({ id }) => (id === 'auto-generated-group-footer-root' ? 'auto' : undefined),
    [],
  );
  

and this worsens performance even more than what is described above

@Vagizova Vagizova changed the title [datagrid] add separate render method for aggregation row [data grid] add separate render method for aggregation row Oct 27, 2024
@michelengelen
Copy link
Member

Might be worth exploring ... the findings make sense, even if we provide an optional override with the default set to the cellRenderer. I would call it renderAggregationCell though, just to be consistent with the naming! 👍🏼

I'll add this to the board as a feature request!

Thanks for opening this @Vagizova

@michelengelen michelengelen added component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 29, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Oct 29, 2024
@oliviertassinari oliviertassinari changed the title [data grid] add separate render method for aggregation row [data grid] Add separate render method for aggregation row Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature new feature New feature or request
Projects
Status: 🆕 Needs refinement
Development

No branches or pull requests

2 participants