Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump x-license-pro package peerDependency to accept React 19 #15907

Closed
damischa1 opened this issue Dec 16, 2024 · 6 comments
Closed

Bump x-license-pro package peerDependency to accept React 19 #15907

damischa1 opened this issue Dec 16, 2024 · 6 comments
Labels
package: x-license Specific to @mui/x-license. status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it

Comments

@damischa1
Copy link

x-license-pro has peer dependency as follows peer react@"^17.0.0 || ^18.0.0".

React 19 is not accepted but it is already stable.

Please update dependencies to accept React 19.

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 16, 2024
@cherniavskii
Copy link
Member

Hi @damischa1
Are you using v6 of MUI X packages?
We have added React 19 support in https://github.com/mui/mui-x/releases/tag/v7.23.0 since v7 is the latest major and we're working on v8 alpha.

@cherniavskii cherniavskii added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 16, 2024
@damischa1
Copy link
Author

Hello,

in my package json I have. For the license package the 6.x is latest:
"@mui/icons-material": "^6.2.0",
"@mui/material": "^6.2.0",
"@mui/x-data-grid": "^7.23.2",
"@mui/x-data-grid-pro": "^7.23.2",
"@mui/x-license-pro": "^6.10.2",

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Dec 16, 2024
@LukasTy
Copy link
Member

LukasTy commented Dec 16, 2024

@damischa1 Starting with v7 we have renamed the license package to resemble its intent better.
Please follow this migration section to complete your upgrade to v7. 😉

@LukasTy LukasTy added status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it package: x-license Specific to @mui/x-license. status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 16, 2024
@damischa1
Copy link
Author

Ok. Sorry for invalid report. My issue was fixed by changint the package name to @mui/x-license and changing the version to 7.x. Thank you.

@damischa1
Copy link
Author

Closed

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Dec 16, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@damischa1 How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@github-actions github-actions bot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: x-license Specific to @mui/x-license. status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it
Projects
None yet
Development

No branches or pull requests

3 participants