-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Slow Sparkline on /material-ui/getting-started/templates/dashboard/ #16018
Comments
I had similar results when I benchmarked the performance of that template a few months ago. By personal experience, I don't think we'll get that column to an acceptable performance by tweaking charts code. React+svg+charts is a bad combo for performance, we need to replace at least one of those aspects to offer good performance. |
@zanivan @alexfauquette what if we were to render something else on that data grid? I'm afraid it's too slow, discrediting the whole page, when it might be a Sparkline only issue. @romgrk I dove a bit deeper to understand why the Spackline is slow with #9799 (comment). It felt like the current bottleneck is emotion. Responsible for a +50% degradation of performance. I can imagine a canvas would be +90% faster, thought, it's not clear if most developers would want us to make this tradeoff. |
Right now the How high of a priority do you think this should be in broad terms? I ask because right now we see it as an improvement, but not high on the list due to the amount of necessary work vs perceived return compared to the other topics in our list. Eg: V8 Breaking changes and new pro features. |
Steps to reproduce
Steps:
Context
In my view, this is super important, a demo that doesn't pass webvitals is a demo that doesn't exist. I mean, it's not usable in production.
At 100ms, this starts to be great, e.g. https://dashboard.tremor.so/details
Root cause
The root of the issue seems to be with this column:
I can measure that 90% of the time is spent rendering this.
The root cause might be #9799. Now, it's really weird, I can reproduce this https://stackoverflow.com/questions/52991688/significantly-higher-performance-in-react-whilst-profiling-with-chrome
When I enable profiling mode, it's so much faster 😆, so no longer a true issue.
So maybe the INP reported by https://pagespeed.web.dev/ is actually the theme toggle:
The text was updated successfully, but these errors were encountered: