Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh challenge #3

Open
1 of 2 tasks
oliviertassinari opened this issue Sep 24, 2023 · 4 comments
Open
1 of 2 tasks

Refresh challenge #3

oliviertassinari opened this issue Sep 24, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 24, 2023

We could:

"react": "^17.0.2",

  • Update Next.js to the pages directory

export default class MyDocument extends Document {

@Janpot
Copy link
Member

Janpot commented Sep 26, 2023

Honestly, I'm not sure we should push candidates even deeper into Next.js's paradigms. It's so opinionated and aimed at the static website use-case. It has these strong constraints on routing, it doesn't support API routes, it's all vendor specific and non-standardized. I'd like to gauge candidates capability to understand the basics of React, and the basic anatomy of web servers. If anything, I think for the future of this challenge we could rather aim towards getting rid of Next.js and offer something more bare bones.

Opening #4 already for the dependencies.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 2, 2023

On

Screenshot 2023-10-02 at 17 22 39

this is something that has already surfaced in the past with @samuelsycamore, @danilo-leal, and @mj12albert. I think there is already a general consensus on this, I had the same pain. I have added the point to the TODO list in mui/material-ui#34905 (in cases there is no existing issues about it already)

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 2, 2023

Honestly, I'm not sure we should push candidates even deeper into Next.js's paradigms. It's so opinionated and aimed at the static website use-case. It has these strong constraints on routing, it doesn't support API routes, it's all vendor specific and non-standardized. I'd like to gauge candidates capability to understand the basics of React, and the basic anatomy of web servers. If anything, I think for the future of this challenge we could rather aim towards getting rid of Next.js and offer something more bare bones.

@Janpot Should we go down the Vite + express API route then?

@Janpot
Copy link
Member

Janpot commented Oct 2, 2023

🙂 I typed that comment because I got frustrated with the example. I removed it again after I started playing around with app dir and this challenge and it didn't feel like a good fit. But fair enough, should have signaled this 👍

Should we go down the Vite + express API route then?

I think that would be a good stack for the challenge. The only thing that holds me back from it is vitejs/vite#12423. It would be a pity doing a coding challenge and then have this bug eat all your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants