Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text component's mode property's binding icon is not vertically aligned #2929

Open
2 tasks done
prakhargupta1 opened this issue Nov 23, 2023 · 1 comment
Open
2 tasks done

Text component's mode property's binding icon is not vertically aligned #2929

prakhargupta1 opened this issue Nov 23, 2023 · 1 comment
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. scope: toolpad-studio Abbreviated to "studio"

Comments

@prakhargupta1
Copy link
Member

prakhargupta1 commented Nov 23, 2023 •
edited
Loading

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Reference screenshot from the new UI revamp:

Screenshot 2023-11-23 at 11 58 50 AM
@prakhargupta1 prakhargupta1 added the bug 🐛 Something doesn't work label Nov 23, 2023
@apedroferreira apedroferreira added the good first issue Great for first contributions. Enable to learn the contribution process. label Nov 23, 2023
@Janpot
Copy link
Member

Janpot commented Nov 26, 2023 •
edited
Loading

To fix this we will change how these property controls work. We will equip each of them with a bindingButton property that can accept a React node. Then let the property control decide where the icon must be rendered.

@prakhargupta1 prakhargupta1 added the scope: toolpad-studio Abbreviated to "studio" label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. scope: toolpad-studio Abbreviated to "studio"
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Janpot @apedroferreira @prakhargupta1