Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mptcpize: use systemd overrides instead of editing vendor provided .service #209

Open
candrews opened this issue Jan 31, 2022 · 2 comments

Comments

@candrews
Copy link

candrews commented Jan 31, 2022

Is your feature request related to a problem? Please describe.

Currently, mptcpize will modify the vendor provided systemd service file located at /lib/systemd/system/*.service.

This approach is problematic because that file can and will change when new versions of the package that owns it are installed. The result is that the mptcpize modification to that file is unexpectedly lost.

Describe the solution you'd like
systemd provides overrides as a solution to this problem. See https://www.freedesktop.org/software/systemd/man/systemd.unit.html

For example, I suggest that mptcpize enable xyz creates a file at /etc/systemd/system/apache2.service.d/mptcpize.conf with these contents:

[Service]
Environment="LD_PRELOAD=/usr/lib64/mptcpize/libmptcpwrap.so"

Furthermore, using the un-versioned library name (libmptcpwrap.so as opposed to libmptcpwrap.so.0.0.1) will avoid unexpected breakage when the version changes in the future.

@candrews candrews changed the title mptcpize: use systemd overrides instead of editting vendor provided .service mptcpize: use systemd overrides instead of editing vendor provided .service Jan 31, 2022
@ossama-othman
Copy link
Member

@pabeni FYI

@ossama-othman ossama-othman added this to the Q1-2022 milestone Feb 17, 2022
@ossama-othman ossama-othman removed this from the Q1-2022 milestone Jun 27, 2022
@matttbe
Copy link
Member

matttbe commented Aug 10, 2022

Good idea!
I confirm it would be clearer and it would help in case of software update! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants