Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance and Communicator both check for connectedness #279

Open
LourensVeen opened this issue Dec 17, 2023 · 1 comment
Open

Instance and Communicator both check for connectedness #279

LourensVeen opened this issue Dec 17, 2023 · 1 comment

Comments

@LourensVeen
Copy link
Contributor

Communicator.receive() takes a default message for when the port is not connected, but Instance.__receive_message() checks for this too, so that this is now implemented twice in different places. Should be investigated and cleaned up.
@LourensVeen
Copy link
Contributor Author

Actually, the check is mostly in Communicator, Instance just does a check to generate a more helpful error message. Maybe a non-issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LourensVeen