Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muscle_settings_in not drained #285

Open
LourensVeen opened this issue Jan 7, 2024 · 0 comments
Open

muscle_settings_in not drained #285

LourensVeen opened this issue Jan 7, 2024 · 0 comments

Comments

@LourensVeen
Copy link
Contributor

At least in the C++ version of libmuscle, it seems like we're not draining muscle_settings_in when closing incoming ports, so that we'll end up hanging if we have something trying to send us new settings while something else that we have an F_INIT port from has quit.

Should check if it's also the case in Python, and fix where needed. And add some regression tests.

Actually, maybe what we should do is make muscle_settings_in as much as possible a normal (although hidden from the user-facing API) port, rather than the special status it has now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant