Skip to content
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.

Drop version definition in overlay.mumblelay #18

Open
Kissaki opened this issue Sep 22, 2019 · 0 comments
Open

Drop version definition in overlay.mumblelay #18

Kissaki opened this issue Sep 22, 2019 · 0 comments

Comments

@Kissaki
Copy link
Member

Kissaki commented Sep 22, 2019

The file overlay.mumblelay contains a version string at

version=1.4.0
.

This may be a technical necessity, but it is very bad architecture because now the Mumble version depends on the themes layout file.

It makes version bumps in Mumble more complex and error prone. mumble-voip/mumble#3799 mumble-voip/mumble#3761

If at all possible the theme must not contain version specific code like this.

@xpoke Is the assumption correct that this is a layout file replacing the existing one for layout changes. And the version number being in there is a side effect because we override the entire file?

So the way to fix this would then to look for a way in Mumble itself to clear it from the layout file? (What is the file used for and how?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant