You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.
If at all possible the theme must not contain version specific code like this.
@xpoke Is the assumption correct that this is a layout file replacing the existing one for layout changes. And the version number being in there is a side effect because we override the entire file?
So the way to fix this would then to look for a way in Mumble itself to clear it from the layout file? (What is the file used for and how?)
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The file
overlay.mumblelay
contains a version string atmumble-theme/overlay.mumblelay
Line 2 in 9c68c14
This may be a technical necessity, but it is very bad architecture because now the Mumble version depends on the themes layout file.
It makes version bumps in Mumble more complex and error prone. mumble-voip/mumble#3799 mumble-voip/mumble#3761
If at all possible the theme must not contain version specific code like this.
@xpoke Is the assumption correct that this is a layout file replacing the existing one for layout changes. And the version number being in there is a side effect because we override the entire file?
So the way to fix this would then to look for a way in Mumble itself to clear it from the layout file? (What is the file used for and how?)
The text was updated successfully, but these errors were encountered: