Midi/drum editor 'snap' drop-down lost a column?

[terminator356]

Just wondering, did someone change that?
The drop-down used to be three columns of 'snap' values, now it's just two.
Are you sure two columns is enough? Will it be OK? What about the other older
values in the missing column?
Or did a bug creep in there?

[spamatica]

Hmm, it sort of rings a bell that I saw something wierd in that area some days ago, but trying now it looks OK. So, don't know what might be amiss.

[terminator356]

Oh, I see now. The other column is there but not being displayed.
I must use the keyboard arrows to get it into view. Mouse alone does not show it.
Maybe with all the font changes recently, that drop-down list suffered something.
Likely its width needs to be adjusted.
We'll have to fix that...

[kybos]

It looks fine here, I haven't noticed anything weird.
AFAIK there were no relevant font changes here, the toolbar has always used the main system font?

[spamatica]

Haven't looked at the code but did a bit of headscratching where I saw it, and it was on the computer where I have a more recent Kubuntu, meaning that it very likely is a Qt thing. Went and started MusE there now and it only shows two columns, so something changed in Qt... Den lör 15 feb. 2020 kl 03:38 skrev Tim <[email protected]>:

…

Oh, I see now. The other column is there but not being displayed. I must use the keyboard arrows to get it into view. Mouse alone does not show it. Maybe with all the font changes recently, that drop-down list suffered something. Likely its width needs to be adjusted. We'll have to fix that... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/orgs/muse-sequencer/teams/musedevteam/discussions/29/comments/2?email_source=notifications&email_token=ABCFAN5XKJVDOW66BYH6TXLRC43DRA5CNFSM4KVRE6VKYY3PNVWWK3TUL52HS4DFWNCGS43DOVZXG2LPNZIG643UKJSXA3DZVJRW63LNMVXHIX3JMTHAAAVVYQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCFAN7WUCCRGDAO6HQ7C33RC43DRANCNFSM4KVRE6VA> .

[terminator356]

I think it's just our drop-down width setting.
I recall this also happened many years ago when I fixed it.
The width was not 'automatic' if I recall, that is, we must set it.
It may be a sort of fixed, or poorly calculated, value.

[terminator356]

OK I applied a fix.
Can you guys check it out? Especially kybos on his display.
There should be three 'snap' columns fitting snugly with no excess movement to either side.
Thanks!

[kybos]

I could reproduce the problem only on Manjaro/KDE in a VM.
With the fix it looks OK now also there.