Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'rest' events have dur nil #6

Open
adcxyz opened this issue Nov 18, 2021 · 1 comment
Open

'rest' events have dur nil #6

adcxyz opened this issue Nov 18, 2021 · 1 comment

Comments

@adcxyz
Copy link
Contributor

adcxyz commented Nov 18, 2021

when a wavesetsevent-generated event has type \rest, it has a duration of nil,
which can be surprising when you use event[\dur] to calculate other values -
It took me a long while to figure out where exactly a rare error in a wavesets patch happened.

Maybe WavesetsEvent should have an instance variable restDur with a safe default value,
e.g. 0.01 or so, so even if it goes into a no-wavesets=found loop, it does not lock up?

@telephon
Copy link
Contributor

Hm, could we risk to make it zero?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants