-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: Can't apply the needed filtering without introducing a lot of digital noise #40
Comments
If i understand correctly, the issue most likely related to lack of headroom in the EQ code. You could try to lower the value in SoftwareVolumeProcessor.cpp (default volume to something lower) in order to simulate it, but its not really the best solution. |
was looking at that code. Does the µVox driver override this code?
Because when running higher than 24 we are adding gain. |
Oh, and this artifacts seems to be there with even very low volume. Are we touches gain somewhere else in the platform? With this recent test I am doing a high pass shelf with negative gain. This should really not introduce clipping |
are the processor out of juice? And any good way to verify this? |
Assuming the problem is missing EQ headroom, is there any way I can validate whether or not we are close to the limit? It enters as Been using Camila DSP with the same set of filters and there it is working pretty good. Any idea on when and where this is converted to a 32bit one (if at all)? Any other great ideas of where to look? |
I am a bit lost here. Tried looking at various classes, but didn't find any smoking gun. So any clue on the maximum value? Data coming in:
Data coming out:
|
Hi! Could you send me a list of different filters you are using? I would like to test it out on my setup and debug :) |
Sure thing. The list is long, but basically having problems with the default setup as well. But here's the entire list of filters needed as it is represented by the Camilla DSP YAML format: https://github.com/LydByDissing/stroem/blob/main/voicing/voicing-dsp-filters-descent.yaml |
BTW, any reason why the coefficient helper functions, in the ESP DSP Library, isn't used in this project? Based on the benchmark documentation of |
As for Euphonium being software targetted for multiple different architectures, I did not use esp-dsp directly. However, on ESP32 platform it does actually back up to using an assembly optimized |
Makes sense. Yes I saw that you are using the ASM implementation. My comment was mainly on the calculations of the filter coefficients. But as this will need to be used for multi platforms it makes sense, not to depend on that library. |
Hey,
When adding additional filters or when tuning the EQ up to +12, then I hear pretty bad digital noise. It sounds like clipping, but could also be something else.
Not sure how and where to test for this?
I also tried reducing the signal by 50% by multiplying with 0.5. But the digital artifacts still persisted. So it most be somewhere else in the chain.
The text was updated successfully, but these errors were encountered: