Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: mux-player childList observer behavior #1038

Closed
1 task done
IlyaRazuvaev opened this issue Dec 11, 2024 · 0 comments · Fixed by #1041
Closed
1 task done

Bug: mux-player childList observer behavior #1038

IlyaRazuvaev opened this issue Dec 11, 2024 · 0 comments · Fixed by #1041
Labels
bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@IlyaRazuvaev
Copy link

IlyaRazuvaev commented Dec 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply

mux-player

Which browsers are you using?

Chrome

Which operating systems are you using?

macOS

Description

Hello!
I'm working on integrating a custom element into mux-player, and I'm having trouble with web components. I need to insert an element into mux-player with styles that are loaded directly into the page.
I'm using a similar approach to how Mux handles the poster slot, passing the element through the slot tree like this:

<slot name="my-slot" slot="my-slot"></slot>

However, when I do this, the internal structure of my custom element is unexpectedly copied into the mux-video element, which breaks the UI of player element.

Reduced test case

https://codesandbox.io/p/sandbox/t86gpf?file=%2Findex.html%3A7%2C35

Steps to reproduce

  1. Open sandbox
  2. Observe elements of mux-video
    Image

Current Behavior

Elements are copied

Expected Behavior

Top level elements are copied only. (My assumption based on the review of the code related to @mux-player/src/video-api)

Errors

No response

What version of the package are you using?

Latest

@IlyaRazuvaev IlyaRazuvaev added bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Dec 11, 2024
@luwes luwes closed this as completed in d34903f Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant