Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: mux-uploader-retry not shown on upload error + retry not reseting mux-uploader-progress #874

Closed
1 task done
theazgra opened this issue Feb 22, 2024 · 2 comments · Fixed by #906
Closed
1 task done
Labels
bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@theazgra
Copy link

theazgra commented Feb 22, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply

mux-uploader

Which browsers are you using?

Edge ("Edgeium")

Which operating systems are you using?

Windows

Description

I am reporting two bugs in one issue.

Reduced test case

https://gist.github.com/theazgra/2c88938a3198540b6e6ecb9324e47d3c

Steps to reproduce

  1. Provide invalid endpoint url to trigger upload-error
  2. Try to upload video/audio
  3. Upload fails

Current Behavior

Upload fails. Correct status message (error message) is shown. But retry button (<mux-uploader-retry>) is not shown.

image

Also when i modify HTML in inspector, showing the <mux-uploader-retry> button, clicking in doesn't reset <mux-uploader-progress> element state. This is screenshot after click the button:
image

Expected Behavior

  • <mux-uploader-retry> is shown, when upload fails. Allowing user to click the button.
  • state of <mux-uploader-progress> is reseted after reseting uploader state (progress bar and percentage are hidden)

Errors

No response

What version of the package are you using?

1.0.0-beta.6

@theazgra theazgra added bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Feb 22, 2024
@cjpillsbury
Copy link
Contributor

Thanks for filing the detailed issue and the handy screenshots. Our team's a bit stacked in our priority queue right now, but I'll be sure to keep you posted if/when we're able to make progress on this!

@cjpillsbury
Copy link
Contributor

Hey @theazgra I'm hoping to be able to pick this up soon. Do you happen to know if this issue was unique to Windows+Edge, or does it show up on other browsers as well (windows or otherwise)?

cjpillsbury added a commit that referenced this issue Apr 18, 2024
* Upgrade upchunk for various fixes that are relied on for mux-uploader
improvements
* Account for various state update permutations
* Account for offline
* Use Attribute Selectors + CSS instead of programmatic style updates
* Prefer `toggleAttribute()` for boolean attrs usage.
* Fixes #874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants