fix: Mux-player childList observer behavior #1039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of append only parent
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
genadis
force-pushed
the
fix/mux-player-observer
branch
from
921d071 to
787b109
Compare
|
thanks for contribution! does removing the |
…id copy of subtree nodes
|
Thanks for the suggestion! This is much better. |
|
Thanks for making that change! I just thought of another way which we improved recently, I'm gonna add a commit here if it's possible with those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1038
My fix is based on the assumption that this part of code is correct. And only top level children should be copied.
