feat: Rename new default theme #771
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=======================================
Coverage 82.16% 82.16%
=======================================
Files 40 40
Lines 7868 7868
Branches 457 457
=======================================
Hits 6465 6465
Misses 1397 1397
Partials 6 6 |
There was a problem hiding this comment.
could we have a few more people review this? @heff @mmcc
it's in fun spirit which I like but it feels disconnected to me.
to me it didn't ring any bells, daniel or gerwig.
also how do these fit with the other themes minimal and microvideo?
in the future in player.style?
I'm leaning more to keep classic and just a new catchy name for the new theme.
it's pink and bubbly. gerwig doesn't feel very catchy to me
|
Happy to get input from 👆, but since this is naming the official elements themes, I believe Dylan would be a a more appropriate reviewer/decision maker to loop in.
This was based on a conversation with @dylanjha and I had that some other folks chimed in on out of band. The idea was taking our own spin on codenames like e.g. Android's, where the name is honoring a writer/director of a movie from the year that the theme was created (to that end, I'm not sure if we settled on "daniel" vs. "kwan" out of band). Like the Android or other naming conventions, they typically aren't going to have hard associations outside of the place that's establishing them (what does "eclair" or "froyo" mean outside of the fact that folks expect Android OS codenames to be desert-y? Will it tell you which version something is, or when it was made, etc.?).
We've previously decided that we were going to treat the "official" mux player themes differently from "generic media chrome themes," not just in where the code for the themes live (part of elements/mux player package as opposed to e.g. media chrome), but in how we will/won't treat them as "readily usable for things other than mux player". Even though we designed things like the |
|
It's also worth noting that we could also treat these as "aliases" and simply keep the year or some other versioning in place so folks could use either/both to reference their theme, whatever "fun codename" we decide to assign. |
@luwes -- can you make a suggestion for a new name?
Gerwig is a reference to Greta Gerwig, which is the director of Barbie (pink and bubbly), seems okay to me? I'm open to other suggestions. Can also go with |
|
I think keeping |
|
@cjpillsbury yep, I saw the Slack convo's. that's why I didn't cc Dylan because he's in the loop. pink, bubbly -> barbie -> gerwig is a step too far IMO. why not call it barbie then? easier to remember other suggestions: bubblegum, rosa (rose), pinkpop, pinkfizz, jellyfish, |
luwes
dismissed
their stale review
gerwig for the new theme I can adapt too
|
Cool. No notes on my side. |
AdamJaggard
changed the title
AdamJaggard
force-pushed
the
feat/theme-renaming
branch
from
ac832c0 to
0881ee4
Compare
|
@cjpillsbury, @dylanjha, @luwes, I've reverted old theme back to As this now only affects the new theme, it's a safer merge. |
classicis nowdaniel,2023is nowgerwigThis is technically a breaking change but because no one is likely aware that these recent exports exist we can decide how we want to handle merging. Seeing as switching to the new default theme is going to be a major version bump anyway we may want to hold off merging until we are preparing for that release?Old theme is remaining as
classic, new theme is nowgerwig.