Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seektoliveoffset attribute #958

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add seektoliveoffset attribute #958

wants to merge 4 commits into from
+77 −13

Conversation

k-g-a
Copy link
Contributor

@k-g-a k-g-a commented Aug 16, 2024

  1. Implements Add seekToLiveOffset attribute #923, adds documentation (with motivation).
  2. Fixes a regression of noautoseektolive not being used at all
  3. Fixes a couple of broken links in docs.

@k-g-a k-g-a requested review from heff and a team as code owners August 16, 2024 08:19
@vercel Vercel
Copy link

vercel bot commented Aug 16, 2024

@k-g-a is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@k-g-a
feat(media-controller): add seektoliveoffset attribute (muxinc#923)
6ad2337 
This attribute is used within seek to live and play requests to offset the current time from the very end of the seekable range to prevent high chance of stalling afterwards. If not specified, defaults to liveedgeoffset.
@k-g-a
fix(media-controller): fix noAutoSeekToLive not working regression
026b78a
@k-g-a
docs(media-controller): fix liveedgeoffset's 'see also' links
9a05feb
@k-g-a
docs(media-controller): add seektoliveoffset documentation
3ba89cd
@k-g-a k-g-a force-pushed the add-seektoliveoffset branch from f3f22dc to 3ba89cd Compare September 17, 2024 07:16
@luwes
Copy link
Contributor

luwes commented Sep 17, 2024

thank you for the contribution! I'll bring this up with the team.

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.40741% with 23 lines in your changes missing coverage. Please review.

Project coverage is 78.94%. Comparing base (3ea80df) to head (3ba89cd).
Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
src/js/media-controller.ts 29.62% 19 Missing ⚠️
src/js/media-store/request-map.ts 73.33% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   78.55%   78.94%   +0.38%     
==========================================
  Files          59       50       -9     
  Lines       11080    12101    +1021     
  Branches        0      771     +771     
==========================================
+ Hits         8704     9553     +849     
- Misses       2376     2548     +172

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k-g-a
Copy link
Contributor Author

k-g-a commented Sep 26, 2024

Hi, @luwes!

I'd like to fix the coverage issue of this PR, but, unfortunatelly, I could not find any examples of working with live streams in test cases. So I'm open to ideas/suggestions to implement.

@k-g-a
Copy link
Contributor Author

k-g-a commented Nov 25, 2024

Hi, @luwes!

Any update on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heff heff Awaiting requested review from heff heff is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-g-a @luwes