Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the old ColorSpace Node be marked as deprecated? #211

Closed
danielmuellerma opened this issue Aug 28, 2024 · 0 comments · Fixed by #251
Closed

Should the old ColorSpace Node be marked as deprecated? #211

danielmuellerma opened this issue Aug 28, 2024 · 0 comments · Fixed by #251
Labels
gdtf spec low-hanging-fruit something that looks easy to adopt and brings value to GDTF and MVR

Comments

@danielmuellerma
Copy link
Contributor

So far there is no definition whether the first color space should be exported to the ColorSpace node and all others to the AdditionalColorSpaces collect. The Builder exports all ColorSpaces to the AdditionalColorSpaces collect, which makes sense to me. Should the "old" ColorSpace node be marked as deprecated (like the Connectors node)?
@danielmuellerma danielmuellerma added gdtf spec low-hanging-fruit something that looks easy to adopt and brings value to GDTF and MVR labels Aug 28, 2024
@danielmuellerma danielmuellerma mentioned this issue Jan 9, 2025
Merged
@danielmuellerma danielmuellerma linked a pull request Jan 9, 2025 that will close this issue
deprecated the old color space node #251
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gdtf spec low-hanging-fruit something that looks easy to adopt and brings value to GDTF and MVR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deprecated the old color space node mvrdevelopment/spec
1 participant
@danielmuellerma