Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify when a channel set's wheel slot contains color and when it is open #214

Open
petrvanekrobe opened this issue Sep 10, 2024 · 4 comments
Assignees

Comments

@petrvanekrobe
Copy link
Contributor

petrvanekrobe commented Sep 10, 2024

A channel set of some channel functions linked to a wheel (for example Color(n)) requires a wheel slot to be linked. Add a way to more clearly indicate if the slot means "open". A wheel slot cannot be none. One way would be to add IsOpen flag to the set.

@petrvanekrobe
Copy link
Contributor Author

TODO:

  • add an enum for "open", "closed", this will preserve backwards compatibility
  • document the mutual exclusivity, given by the GDTF attribute in the defining ChannelFunction, i.e.
    • Color(n) - png image (if present) or filter (if present) or color
    • Gobo(n) - png image
    • Prism(n) - prism slots
    • AnimationSystem(n) - animation wheel
    • ...

@danielmuellerma
Copy link
Contributor

AnimationWheel(n) - png image
MediaContent(n) - png image?
ModelContent(n) - ?

@danielmuellerma
Copy link
Contributor

  • AnimationSystem(n) - animation wheel

png image + animation wheel

@petrvanekrobe
Copy link
Contributor Author

@danielmuellerma i have started this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants