Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments on the definition of SubPhysicalUnits and SubChannelSets #218

Open
danielmuellerma opened this issue Sep 30, 2024 · 0 comments
Open

Adjustments on the definition of SubPhysicalUnits and SubChannelSets #218

danielmuellerma opened this issue Sep 30, 2024 · 0 comments
Labels
gdtf spec low-hanging-fruit something that looks easy to adopt and brings value to GDTF and MVR

Comments

@danielmuellerma
Copy link
Contributor

  1. Let us discuss whether there is any benefit in having PhysicalFrom and PhysicalTo defined as default physical values per SubPhysicalUnit.
    If not:
    remove PhysicalFrom and PhysicalTo from the SubPhysicalUnit
    add default of 0 to PhysicalFrom of SubChannelSet
    add default of 1 to PhysicalTo of SubChannelSet

  2. Since SubPhysicalUnits describe additional physical units of an attribute, the default of "PhysicalUnit" should not be "None". In fact, we should remove "None" altogether.
@danielmuellerma danielmuellerma added gdtf spec low-hanging-fruit something that looks easy to adopt and brings value to GDTF and MVR labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gdtf spec low-hanging-fruit something that looks easy to adopt and brings value to GDTF and MVR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielmuellerma