Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "TODO" from description of the PrimitiveType attribute. #224

Closed
danielmuellerma opened this issue Oct 8, 2024 · 2 comments · Fixed by #252
Closed

Remove "TODO" from description of the PrimitiveType attribute. #224

danielmuellerma opened this issue Oct 8, 2024 · 2 comments · Fixed by #252
Labels
gdtf spec low-hanging-fruit something that looks easy to adopt and brings value to GDTF and MVR

Comments

@danielmuellerma
Copy link
Contributor

https://github.com/mvrdevelopment/spec/blob/main/gdtf-spec.md#user-content-table-32

Or is the TODO there intentionally and we missed something?
@danielmuellerma danielmuellerma added gdtf spec low-hanging-fruit something that looks easy to adopt and brings value to GDTF and MVR labels Oct 8, 2024
@Verschwiegener
Copy link
Contributor

Would a cone be necessary to add or would that fall under Cylinder?

@petrvanekrobe
Copy link
Contributor

Would a cone be necessary to add or would that fall under Cylinder?

Custom models can always be uploaded if a cone (not that used from what i can see) is required for some devices.

@danielmuellerma danielmuellerma mentioned this issue Jan 9, 2025
Merged
@danielmuellerma danielmuellerma linked a pull request Jan 9, 2025 that will close this issue
Removed "TODO" from description of the PrimitiveType attribute #252
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gdtf spec low-hanging-fruit something that looks easy to adopt and brings value to GDTF and MVR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed "TODO" from description of the PrimitiveType attribute mvrdevelopment/spec
3 participants
@danielmuellerma @petrvanekrobe @Verschwiegener